Glasgow | 26-ITP-May | Sandani Kannangara | Sprint 3 | Practice Tdd#1382
Open
SandzSoft wants to merge 4 commits into
Open
Glasgow | 26-ITP-May | Sandani Kannangara | Sprint 3 | Practice Tdd#1382SandzSoft wants to merge 4 commits into
SandzSoft wants to merge 4 commits into
Conversation
SandzSoft
added
📅 Sprint 3
cjyuan
reviewed
Jun 27, 2026
| expect(getOrdinalNumber(3)).toEqual("3rd"); | ||
| expect(getOrdinalNumber(33)).toEqual("33rd"); | ||
| }); | ||
| test("appends th for all other numbers", () => { |
Contributor
There was a problem hiding this comment.
When a test fails with the message "... all other numbers", it may be unclear what "other numbers" actually refers to.
Can you revise the test description to make it more informative?
Author
There was a problem hiding this comment.
Thank you for the feedback. I've updated the test description to make the category of numbers more specific and informative.
cjyuan
added
Reviewed
SandzSoft
added
Needs Review
Contributor
|
Changes look good. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Completed Sprint 3 practice TDD exercises.
Implemented and tested the following functions:
Added both implementation logic and Jest test coverage for all functions, including edge cases and invalid inputs.